feat(integrations): Support Django 5.0#2490
Merged
Merged
Conversation
…try/sentry-python into antonpirker/django_asgi_read_body
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks good, besides the small comments I left regarding deprecated portions of typing
sentrivana
enabled auto-merge (squash)
November 14, 2023 12:35
sentrivana
disabled auto-merge
November 14, 2023 12:36
sentrivana
enabled auto-merge (squash)
November 14, 2023 12:37
Contributor
|
Please consider something similar for Django v5.1b1 which was released today. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run our Django test suite on Django 5.0 (beta) and make sure the tests pass.
Fix the way we wrap signal receivers: Django 5.0 introduced async receivers and changed the signature of the
Signal._live_receiversmethod to return both sync and async receivers. We are just ignoring the async receivers in this PR (and not wrapping them to create spans) since ASGI Django doesn't create transactions.We'll need to change the Django version in tox.ini to 5.0 once it's been released. At the moment we're using the 5.0b1 release.
See #2489
Closes #2383